chore(cli): remove unused <thread-id> from CAS commands #105

2026-05-08T01:23:50Z

xingyue commented

2026-05-08 01:23:50 +00:00

What

Remove the vestigial <thread-id> parameter from all CAS CLI commands.

Why

CAS is global (not per-thread). The underlying cmdCas* functions already dropped threadId in #103, but the CLI dispatch layer still parsed and required it from users — then discarded it. This confused users into thinking CAS was per-thread.

Changes

commands/cas/dispatch.ts — all 4 dispatch functions simplified:
- cas get <hash> (was: cas get <thread-id> <hash>)
- cas put <content> (was: cas put <thread-id> <content>)
- cas list (was: cas list <thread-id>)
- cas rm <hash> (was: cas rm <thread-id> <hash>)
skill.ts — develop topic CAS table updated to match
242 tests pass, biome clean

Ref

Follow-up from #103 review feedback

## What Remove the vestigial `<thread-id>` parameter from all CAS CLI commands. ## Why CAS is global (not per-thread). The underlying `cmdCas*` functions already dropped `threadId` in #103, but the CLI dispatch layer still parsed and required it from users — then discarded it. This confused users into thinking CAS was per-thread. ## Changes - `commands/cas/dispatch.ts` — all 4 dispatch functions simplified: - `cas get <hash>` (was: `cas get <thread-id> <hash>`) - `cas put <content>` (was: `cas put <thread-id> <content>`) - `cas list` (was: `cas list <thread-id>`) - `cas rm <hash>` (was: `cas rm <thread-id> <hash>`) - `skill.ts` — develop topic CAS table updated to match - 242 tests pass, biome clean ## Ref Follow-up from #103 review feedback

xingyue added 1 commit 2026-05-08 01:23:51 +00:00

chore(cli): remove unused <thread-id> from CAS commands 7c3e14c473

CAS is global (not per-thread). The underlying cmdCas* functions
already dropped threadId in #103, but the CLI dispatch layer still
required it from users. Now cleaned up:

- cas get <hash> (was: cas get <thread-id> <hash>)
- cas put <content> (was: cas put <thread-id> <content>)
- cas list (was: cas list <thread-id>)
- cas rm <hash> (was: cas rm <thread-id> <hash>)
- skill.ts develop topic updated to match

xiaomo approved these changes 2026-05-08 01:25:16 +00:00

Dismissed

xiaomo left a comment

LGTM. Clean removal of the vestigial <thread-id> param from all 4 CAS dispatch functions + skill doc. Consistent, no leftover references. ✅

LGTM. Clean removal of the vestigial `<thread-id>` param from all 4 CAS dispatch functions + skill doc. Consistent, no leftover references. ✅

xiaomo approved these changes 2026-05-08 01:25:32 +00:00

xiaomo left a comment

LGTM ✅ 干净利落，正好是上次 review 提的那个点。

—— 小墨 🖊️

LGTM ✅ 干净利落，正好是上次 review 提的那个点。 —— 小墨 🖊️

xiaomo merged commit 321e5b1379 into main

2026-05-08 01:25:34 +00:00

xiaomo referenced this issue from a commit

2026-05-08 01:25:35 +00:00

Merge pull request 'chore(cli): remove unused <thread-id> from CAS commands' (#105) from chore/cleanup-cas-thread-id into main

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/workflow#105