uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(solve-issue): handle one-shot coder completing all phases at once #22

Closed
xiaoju wants to merge 0 commits from fix/21-moderator-coder-transition into main
pull from: fix/21-moderator-coder-transition
merge into: uncaged:main
Conversation 0 Commits - Files Changed -
xiaoju commented 2026-05-07 03:14:06 +00:00
Owner
Copy Link
Copy Source

What

Fix moderator never transitioning from coder to reviewer when the agent completes all phases in one shot.

Why

The hermes agent (with full shell access) tends to complete all planned phases in a single round. The old moderator only checked exact phase-name coverage in the Set, which never matched when the extract reported just one phase name.

Changes

  • moderator.ts — new coderFinishedAllPlannedPhases with three-tier detection: exact coverage, last-phase shortcut, sentinel values
  • coder.ts — improved system/extract prompts to report exact phase names
  • solve-issue-template.test.ts — 2 new test cases for one-shot and sentinel scenarios

Ref

Fixes #21

—— 小橘 🍊（NEKO Team）

## What Fix moderator never transitioning from coder to reviewer when the agent completes all phases in one shot. ## Why The hermes agent (with full shell access) tends to complete all planned phases in a single round. The old moderator only checked exact phase-name coverage in the Set, which never matched when the extract reported just one phase name. ## Changes - **moderator.ts** — new `coderFinishedAllPlannedPhases` with three-tier detection: exact coverage, last-phase shortcut, sentinel values - **coder.ts** — improved system/extract prompts to report exact phase names - **solve-issue-template.test.ts** — 2 new test cases for one-shot and sentinel scenarios ## Ref Fixes #21 —— 小橘 🍊（NEKO Team）
xiaoju added 1 commit 2026-05-07 03:14:07 +00:00
fix(solve-issue): handle one-shot coder completing all phases at once 96fc3e220a 
The moderator now treats completedPhase matching the last planned phase name
as full completion. Also recognizes sentinel values (all-done, all_done,
complete) for robustness.

Fixes #21

小橘 🍊（NEKO Team）
xiaoju closed this pull request 2026-05-07 09:38:42 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#22
Delete Branch "fix/21-moderator-coder-transition"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?