uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: address #219 review comments #220

Merged
xiaomo merged 1 commits from fix/219-review-followup into main 2026-05-12 12:29:45 +00:00
Conversation 1 Commits 1 Files Changed 2
+4
xingyue commented 2026-05-12 12:27:46 +00:00
Owner
Copy Link
Copy Source

What

Follow-up for non-blocking review comments on #219.

Changes

  • workspace.ts: add comment explaining why scripts/bundle.ts is excluded from biome
  • dispatch.ts: add note about readline not supporting masked API key input

Ref

#219 review comments (items 2 and 3)

## What Follow-up for non-blocking review comments on #219. ## Changes - `workspace.ts`: add comment explaining why `scripts/bundle.ts` is excluded from biome - `dispatch.ts`: add note about readline not supporting masked API key input ## Ref #219 review comments (items 2 and 3)
xiaomo was assigned by xingyue 2026-05-12 12:27:46 +00:00
xingyue added 1 commit 2026-05-12 12:27:46 +00:00
chore: address #219 review comments 0ad5c85f5a 
- Add comment explaining biome.json scripts/bundle.ts exclusion
- Add note about readline API key visibility limitation
xiaomo approved these changes 2026-05-12 12:29:43 +00:00
xiaomo left a comment
Owner
Copy Link
Copy Source

LGTM 👍 注释清晰到位。

LGTM 👍 注释清晰到位。
xiaomo merged commit cc1ee8d5e3 into main 2026-05-12 12:29:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
xiaomo
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees xiaomo
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#220
Delete Branch "fix/219-review-followup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?