 xingyue
|
dc5fdd7358
|
fix(dashboard): address ELK layout review feedback
What: Fix three non-blocking issues from PR #232 review.
Why: Code quality — unhandled promise rejection risk, type safety,
and project convention compliance.
Changes:
- packages/workflow-dashboard/src/components/workflow-graph/types.ts:
add elkLabelX/elkLabelY fields to ConditionEdgeData type (number | null,
not optional — per project no-optional-properties rule)
- packages/workflow-dashboard/src/components/workflow-graph/use-layout.ts:
remove 'as ConditionEdgeData' type assertion (now unnecessary),
add .catch() to computeLayout promise
- packages/workflow-dashboard/src/components/workflow-graph/condition-edge.tsx:
remove redundant inline type extension, use ConditionEdgeData directly
Ref: PR #232 review comments
|
2026-05-13 16:37:07 +08:00 |
|