uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#447): reduce cognitive complexity in loop.ts #450

Closed
xingyue wants to merge 3 commits from fix/447-reduce-loop-complexity into main
pull from: fix/447-reduce-loop-complexity
merge into: uncaged:main
Conversation 1 Commits 3 Files Changed 2
+141 -77
xingyue commented 2026-05-23 14:54:23 +00:00
Owner
Copy Link
Copy Source

What

Reduced cognitive complexity in loop.ts by extracting helper functions shouldNudge and executeTurnTools, and added unit tests covering them.

Why

The runBuiltinLoop function exceeded the allowed complexity threshold (max 15). Extracting helpers brings each unit under the limit and makes the logic independently testable.

Changes

  • Extracted shouldNudge and executeTurnTools as exported helpers from loop.ts
  • Added __tests__/loop.test.ts with 8 unit tests covering both helpers and the integration loop

Ref

Fixes #447

## What Reduced cognitive complexity in `loop.ts` by extracting helper functions `shouldNudge` and `executeTurnTools`, and added unit tests covering them. ## Why The `runBuiltinLoop` function exceeded the allowed complexity threshold (max 15). Extracting helpers brings each unit under the limit and makes the logic independently testable. ## Changes - Extracted `shouldNudge` and `executeTurnTools` as exported helpers from `loop.ts` - Added `__tests__/loop.test.ts` with 8 unit tests covering both helpers and the integration loop ## Ref Fixes #447
xingyue added 4 commits 2026-05-23 14:54:23 +00:00
fix #447: extract shouldNudge and export executeTurnTools from loop.ts, add tests 5b68359dfc
fix(#447): reduce cognitive complexity in loop.ts by extracting helpers 64c5122453
fix(#447): format and sort imports in loop.test.ts f63c670cd9
fix(#447): fix biome format in loop.test.ts 842e479784
xiaomo approved these changes 2026-05-23 16:18:07 +00:00
xiaomo left a comment
Owner
Copy Link
Copy Source

LGTM ✅ 行为完全保持一致，提取函数职责清晰。

LGTM ✅ 行为完全保持一致，提取函数职责清晰。
xingyue closed this pull request 2026-05-23 16:25:35 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
xiaomo
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#450
Delete Branch "fix/447-reduce-loop-complexity"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?