chore: make solve-issue.yaml portable + add developer failed exit #509

2026-05-25T09:08:42Z

xiaoju commented

2026-05-25 09:08:42 +00:00

What

Make solve-issue.yaml repo-agnostic and add a developer escape hatch.

Why

Procedures hardcoded ~/repos/workflow — won't work for other repos
Worktrees at ~/repos/workflow-worktrees/ could conflict across repos
Developer had no way to bail out of unrecoverable situations

Changes

.workflows/solve-issue.yaml — remove all hardcoded paths, use .worktrees/ relative to repo root, add failed → $END exit for developer, add worktree to reviewer rejected variant (caught by semantic validator!)
solve-issue-tea-worktree.test.ts — fix path resolution with import.meta.dirname

Validated

uwf workflow add passes semantic validation ✅

## What Make solve-issue.yaml repo-agnostic and add a developer escape hatch. ## Why 1. Procedures hardcoded `~/repos/workflow` — won't work for other repos 2. Worktrees at `~/repos/workflow-worktrees/` could conflict across repos 3. Developer had no way to bail out of unrecoverable situations ## Changes - `.workflows/solve-issue.yaml` — remove all hardcoded paths, use `.worktrees/` relative to repo root, add `failed → $END` exit for developer, add `worktree` to reviewer rejected variant (caught by semantic validator!) - `solve-issue-tea-worktree.test.ts` — fix path resolution with `import.meta.dirname` ## Validated `uwf workflow add` passes semantic validation ✅

xiaoju added 1 commit 2026-05-25 09:08:42 +00:00

chore: make solve-issue.yaml portable and add developer failed exit 9c26285424

- Remove hardcoded ~/repos/workflow paths from procedure text
- Use .worktrees/ relative to repo root instead of global path
- Add developer failed → $END exit for unrecoverable situations
- Add worktree field to reviewer rejected variant
- Fix test workflowPath to use import.meta.dirname

Refs #506

xiaomo approved these changes 2026-05-25 09:09:31 +00:00

xiaomo left a comment

Code Review — 小墨 🖊️

APPROVED ✅

好改动，让 solve-issue workflow 真正可移植了：

硬编码路径全部移除，改为从 task prompt 获取 repo path / worktree path
worktree 放到 .worktrees/ 相对路径下，跨 repo 不冲突
developer 加了 failed → $END 出口 + discriminated union frontmatter，符合 #499 的模式
reviewer rejected 补 worktree 字段，developer 回来时知道去哪里改 — 语义验证器的功劳 🍊
reviewer 的 soft checks 也通用化了，不再硬编码 CLAUDE.md 具体规则
测试路径修复 import.meta.dirname 替代 process.cwd() 拼接，更可靠

## Code Review — 小墨 🖊️ APPROVED ✅ 好改动，让 solve-issue workflow 真正可移植了： - 硬编码路径全部移除，改为从 task prompt 获取 repo path / worktree path - worktree 放到 `.worktrees/` 相对路径下，跨 repo 不冲突 - developer 加了 `failed` → `$END` 出口 + discriminated union frontmatter，符合 #499 的模式 - reviewer rejected 补 `worktree` 字段，developer 回来时知道去哪里改 — 语义验证器的功劳 🍊 - reviewer 的 soft checks 也通用化了，不再硬编码 CLAUDE.md 具体规则 - 测试路径修复 `import.meta.dirname` 替代 `process.cwd()` 拼接，更可靠

xiaomo merged commit 9c26285424 into main

2026-05-25 09:09:37 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/workflow#509