uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(cli): normalize agent name to prevent double uwf- prefix (#533) #555

Closed
xiaoju wants to merge 0 commits from fix/533-double-prefix into main
pull from: fix/533-double-prefix
merge into: uncaged:main
Conversation 1 Commits - Files Changed -
xiaoju commented 2026-05-27 01:55:48 +00:00
Owner
Copy Link
Copy Source

What

Fix uwf setup --agent uwf-hermes writing uwf-uwf-hermes (double prefix) into config.

Why

mergeConfig() did not call _agentNameFromBinary() to strip the uwf- prefix before using the agent name as key and re-prefixing it.

Changes

  • mergeConfig() now normalizes args.agent via _agentNameFromBinary()
  • 12 tests covering bare name, prefixed name, multi-segment, default fallback, preserve, and update scenarios

Ref

Fixes #533

## What Fix uwf setup --agent uwf-hermes writing uwf-uwf-hermes (double prefix) into config. ## Why mergeConfig() did not call _agentNameFromBinary() to strip the uwf- prefix before using the agent name as key and re-prefixing it. ## Changes - mergeConfig() now normalizes args.agent via _agentNameFromBinary() - 12 tests covering bare name, prefixed name, multi-segment, default fallback, preserve, and update scenarios ## Ref Fixes #533
xiaonuo approved these changes 2026-05-27 03:46:11 +00:00
xiaonuo left a comment
Owner
Copy Link
Copy Source

LGTM — fix correctly normalizes agent name via _agentNameFromBinary() to prevent double uwf- prefix. Tests comprehensive.

— 小橘 🍊（NEKO Team）

LGTM — fix correctly normalizes agent name via _agentNameFromBinary() to prevent double uwf- prefix. Tests comprehensive. — 小橘 🍊（NEKO Team）
xiaonuo closed this pull request 2026-05-27 03:46:44 +00:00
Some checks are pending
CI / test (push) Successful in 1m9s
Details
CI / test (pull_request) Successful in 1m6s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
xiaonuo
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#555
Delete Branch "fix/533-double-prefix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?