feat(reviewer): enrich prompt with conventions + CLI awareness #92

2026-05-07T16:20:58Z

xiaoju commented

2026-05-07 16:20:58 +00:00

What

Reviewer system prompt 从 2 行扩展为完整的 review 指南。

Before

You are a code reviewer. Review the current git diff.
Only reject for blocking issues.

After

引导读 preparer 的 conventions 输出
Review checklist：correctness, conventions, consistency, edge cases
文档 PR 验证命令名/包名是否当前有效
Quality bar："false approve costs more than false reject"
引用 uncaged-workflow skill develop

Why

PR #89 实证：reviewer approve 了包含 deprecated CLI 命令的 README，说明旧 prompt 的 quality bar 太低。

Changes

packages/workflow-template-develop/src/roles/reviewer.ts — 1 file, +23 -2

242 tests pass, build clean.

Closes #91

小橘 🍊（NEKO Team）

## What Reviewer system prompt 从 2 行扩展为完整的 review 指南。 ### Before ``` You are a code reviewer. Review the current git diff. Only reject for blocking issues. ``` ### After - 引导读 preparer 的 conventions 输出 - Review checklist：correctness, conventions, consistency, edge cases - 文档 PR 验证命令名/包名是否当前有效 - Quality bar："false approve costs more than false reject" - 引用 `uncaged-workflow skill develop` ## Why PR #89 实证：reviewer approve 了包含 deprecated CLI 命令的 README，说明旧 prompt 的 quality bar 太低。 ## Changes - `packages/workflow-template-develop/src/roles/reviewer.ts` — 1 file, +23 -2 242 tests pass, build clean. Closes #91 --- 小橘 🍊（NEKO Team）

xiaoju added 1 commit 2026-05-07 16:20:59 +00:00

feat(reviewer): enrich prompt with conventions + CLI awareness 9f152ba08d

- Read preparer's conventions from thread context
- Review checklist: correctness, conventions, consistency, edge cases
- Verify CLI commands/package names in docs are current
- Higher quality bar: false approve > false reject
- Reference: uncaged-workflow skill develop

Closes #91

小橘 🍊

xiaoju force-pushed feat/91-reviewer-prompt from 9f152ba08d to 23b2c3b47d

2026-05-07 16:25:35 +00:00

Compare

xiaoju merged commit 2616259a0f into main

2026-05-07 16:27:09 +00:00

xiaoju referenced this issue from a commit

2026-05-07 16:27:10 +00:00

Merge pull request 'feat(reviewer): enrich prompt with conventions + CLI awareness' (#92) from feat/91-reviewer-prompt into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/workflow#92