fix: reviewer prompt — reject or approve, no middle ground
This commit is contained in:
parent
daf07b5746
commit
18e201b49c
@ -15,21 +15,17 @@ Run these commands and analyze the output:
|
|||||||
|
|
||||||
## Checklist
|
## Checklist
|
||||||
|
|
||||||
### 🔴 Must reject (approved: false)
|
### 🔴 Reject (approved: false) — tell coder exactly what to fix
|
||||||
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
||||||
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
||||||
- **Unrelated changes**: files modified outside the scope of the planner's design
|
- **Unrelated changes**: files modified outside the scope of the planner's design
|
||||||
|
- **Debug code**: console.log, debugger statements, TODO/FIXME without context
|
||||||
|
- **Hardcoded paths** that should be configurable
|
||||||
|
- **Missing files** from the planner's design
|
||||||
|
- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing
|
||||||
|
|
||||||
### ⚠️ Flag but may still approve
|
### ✅ Approve (approved: true) — no comment needed
|
||||||
- Debug code left behind (console.log, debugger, TODO/FIXME without context)
|
If everything looks clean, just approve. Do not add suggestions or warnings — they won't be seen.
|
||||||
- Hardcoded paths that should be configurable
|
|
||||||
- Missing type exports that other files might need
|
|
||||||
|
|
||||||
### ✅ Verify
|
|
||||||
- All files from the planner's design are created/modified
|
|
||||||
- Code follows existing patterns (compare with sibling workflows)
|
|
||||||
- Meta types are simple routing signals (single boolean per role)
|
|
||||||
- No dynamic import()
|
|
||||||
|
|
||||||
## Output
|
## Output
|
||||||
|
|
||||||
|
|||||||
@ -15,21 +15,17 @@ Run these commands and analyze the output:
|
|||||||
|
|
||||||
## Checklist
|
## Checklist
|
||||||
|
|
||||||
### 🔴 Must reject (approved: false)
|
### 🔴 Reject (approved: false) — tell coder exactly what to fix
|
||||||
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
||||||
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
||||||
- **Unrelated changes**: files modified outside the scope of the planner's design
|
- **Unrelated changes**: files modified outside the scope of the planner's design
|
||||||
|
- **Debug code**: console.log, debugger statements, TODO/FIXME without context
|
||||||
|
- **Hardcoded paths** that should be configurable
|
||||||
|
- **Missing files** from the planner's design
|
||||||
|
- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing
|
||||||
|
|
||||||
### ⚠️ Flag but may still approve
|
### ✅ Approve (approved: true) — no comment needed
|
||||||
- Debug code left behind (console.log, debugger, TODO/FIXME without context)
|
If everything looks clean, just approve. Do not add suggestions or warnings — they won't be seen.
|
||||||
- Hardcoded paths that should be configurable
|
|
||||||
- Missing type exports that other files might need
|
|
||||||
|
|
||||||
### ✅ Verify
|
|
||||||
- All files from the planner's design are created/modified
|
|
||||||
- Code follows existing patterns (compare with sibling workflows)
|
|
||||||
- Meta types are simple routing signals (single boolean per role)
|
|
||||||
- No dynamic import()
|
|
||||||
|
|
||||||
## Output
|
## Output
|
||||||
|
|
||||||
|
|||||||
@ -15,21 +15,17 @@ Run these commands and analyze the output:
|
|||||||
|
|
||||||
## Checklist
|
## Checklist
|
||||||
|
|
||||||
### 🔴 Must reject (approved: false)
|
### 🔴 Reject (approved: false) — tell coder exactly what to fix
|
||||||
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
||||||
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
||||||
- **Unrelated changes**: files modified outside the scope of the planner's design
|
- **Unrelated changes**: files modified outside the scope of the planner's design
|
||||||
|
- **Debug code**: console.log, debugger statements, TODO/FIXME without context
|
||||||
|
- **Hardcoded paths** that should be configurable
|
||||||
|
- **Missing files** from the planner's design
|
||||||
|
- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing
|
||||||
|
|
||||||
### ⚠️ Flag but may still approve
|
### ✅ Approve (approved: true) — no comment needed
|
||||||
- Debug code left behind (console.log, debugger, TODO/FIXME without context)
|
If everything looks clean, just approve. Do not add suggestions or warnings — they won't be seen.
|
||||||
- Hardcoded paths that should be configurable
|
|
||||||
- Missing type exports that other files might need
|
|
||||||
|
|
||||||
### ✅ Verify
|
|
||||||
- All files from the planner's design are created/modified
|
|
||||||
- Code follows existing patterns (compare with sibling workflows)
|
|
||||||
- Meta types are simple routing signals (single boolean per role)
|
|
||||||
- No dynamic import()
|
|
||||||
|
|
||||||
## Output
|
## Output
|
||||||
|
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user