xiaoju/nerve-workspace
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(solve-issue): align committer/publish prompts and conventions with agent workflow #11

Closed
xiaoju wants to merge 0 commits from refactor/9-committer-agent-workflow into master
pull from: refactor/9-committer-agent-workflow
merge into: xiaoju:master
Conversation 0 Commits - Files Changed -
xiaoju commented 2026-04-29 11:08:16 +00:00
Owner
Copy Link

What

Aligns the solve-issue workflow prompts and CONVENTIONS.md with the actual Hermes agent-based committer/publish architecture described in issue #9. Adds Fixes #N to the publish prompt, guards against empty PRs in the committer prompt, and synchronises documentation.

Why

Issue #9 identified that the committer role had been migrated to a Hermes agent (createRole) but documentation and prompt details lagged behind — missing Fixes #N linkage in publish, outdated Role Patterns table in CONVENTIONS.md, and no defaultBranch guard to prevent empty-diff PRs.

Changes

  • workflows/solve-issue/roles/publish/prompt.ts — require Fixes #<number> line in the Ref section
  • CONVENTIONS.md — update Role Implementation Patterns and Meta Convention tables to match actual createRole(hermesAdapter, …) usage and { committed: boolean } / { success: boolean } schemas
  • workflows/solve-issue/roles/committer/prompt.ts — add defaultBranch verification step before branching to prevent empty PRs
  • workflows/solve-issue/roles/implement/prompt.ts — strengthen git commit prohibition wording

Ref

Fixes #9
#9

## What Aligns the solve-issue workflow prompts and CONVENTIONS.md with the actual Hermes agent-based committer/publish architecture described in issue #9. Adds `Fixes #N` to the publish prompt, guards against empty PRs in the committer prompt, and synchronises documentation. ## Why Issue #9 identified that the committer role had been migrated to a Hermes agent (`createRole`) but documentation and prompt details lagged behind — missing `Fixes #N` linkage in publish, outdated Role Patterns table in CONVENTIONS.md, and no defaultBranch guard to prevent empty-diff PRs. ## Changes - **`workflows/solve-issue/roles/publish/prompt.ts`** — require `Fixes #<number>` line in the Ref section - **`CONVENTIONS.md`** — update Role Implementation Patterns and Meta Convention tables to match actual `createRole(hermesAdapter, …)` usage and `{ committed: boolean }` / `{ success: boolean }` schemas - **`workflows/solve-issue/roles/committer/prompt.ts`** — add defaultBranch verification step before branching to prevent empty PRs - **`workflows/solve-issue/roles/implement/prompt.ts`** — strengthen git commit prohibition wording ## Ref Fixes #9 https://git.shazhou.work/xiaoju/nerve-workspace/issues/9
xiaoju added 1 commit 2026-04-29 11:08:17 +00:00 
- publish/prompt.ts: require 'Fixes #N' in Ref section to auto-close issues
- CONVENTIONS.md: update Role Patterns table (committer uses createRole hermesAdapter), fix Meta Convention (committed not success)
- committer/prompt.ts: add defaultBranch guard before branch creation to prevent empty PR diffs
- implement/prompt.ts: strengthen git commit prohibition

Refs #9
xiaoju added 1 commit 2026-04-29 11:09:04 +00:00
xiaoju closed this pull request 2026-04-29 11:13:00 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
xiaoju
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoju/nerve-workspace#11
No description provided.
Delete Branch "refactor/9-committer-agent-workflow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?