xiaoju/nerve-workspace
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: decouple adapters from workflow factories + createXxxRole #16

Merged
xiaoju merged 3 commits from refactor/15-decouple-adapters into master 2026-04-29 12:44:19 +00:00
Conversation 0 Commits 3 Files Changed 25 +337 -221
xiaoju commented 2026-04-29 12:35:18 +00:00
Owner
Copy Link

What

  • Workflow factories renamed to create* and accept adapters: Record<string, AgentFn>
  • Each role file exports createXxxRole(adapter, ...) — self-contained
  • _shared/workspace-committer accepts adapter as first param
  • All adapter imports consolidated in index.ts (injection point)
  • solve-issue roles also updated

pnpm build passes ✅

Closes #15

## What - Workflow factories renamed to `create*` and accept `adapters: Record<string, AgentFn>` - Each role file exports `createXxxRole(adapter, ...)` — self-contained - `_shared/workspace-committer` accepts adapter as first param - All adapter imports consolidated in `index.ts` (injection point) - solve-issue roles also updated `pnpm build` passes ✅ Closes #15
xiaoju added 1 commit 2026-04-29 12:35:19 +00:00 
- Rename build* → create* workflow factories
- Workflow factories accept adapters: Record<string, AgentFn>
- Each role file exports createXxxRole(adapter, ...) factory
- _shared/workspace-committer accepts adapter as first param
- All adapter imports moved to index.ts (injection point)
- solve-issue roles also updated

Closes #15
xiaoju added 1 commit 2026-04-29 12:38:24 +00:00 
- Each workflow factory takes defaultAdapter: AgentFn + adapters?: Partial<Record<RoleUnion, AgentFn>>
- index.ts only overrides roles that differ from default (planner/coder use cursor, rest fallback)
- Cleaner call sites, type-safe role names

Refs #15
xiaoju added 1 commit 2026-04-29 12:41:15 +00:00
xiaoju merged commit ac47daa42b into master 2026-04-29 12:44:19 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
xiaoju
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoju/nerve-workspace#16
No description provided.
Delete Branch "refactor/15-decouple-adapters"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?