Merge pull request 'fix(dashboard): address ELK layout review feedback' (#233) from fix/dashboard-elk-review-feedback into main

2026-05-13 08:40:32 +00:00
parent bb1293f6b9 dc5fdd7358
commit 39540d9ae8
3 changed files with 14 additions and 5 deletions
@@ -20,7 +20,7 @@ export function ConditionEdge(props: EdgeProps) {
    data,
    markerEnd,
  } = props;
-  const edgeData = data as (ConditionEdgeData & { elkLabelX?: number | null; elkLabelY?: number | null }) | undefined;
+  const edgeData = data as ConditionEdgeData | undefined;
  const isFallback = edgeData?.isFallback ?? false;
  const isSelfLoop = source === target;

@@ -21,6 +21,8 @@ export type ConditionEdgeData = {
  condition: string;
  conditionDescription: string | null;
  isFallback: boolean;
+  elkLabelX: number | null;
+  elkLabelY: number | null;
  [key: string]: unknown;
 };

@@ -99,7 +99,7 @@ function buildEdge(e: WorkflowGraphEdge, elkEdgeMap: Map<string, ElkExtendedEdge
      isFallback,
      elkLabelX: labelX,
      elkLabelY: labelY,
-    } as ConditionEdgeData,
+    },
  };
 }

@@ -195,9 +195,16 @@ export function useLayout(input: LayoutInput): LayoutResult {
      roles: JSON.parse(roleJson) as Record<string, { description: string }>,
      nodeStates: input.nodeStates,
    };
-    computeLayout(parsed).then((result) => {
-      if (!cancelled) setLayout(result);
-    });
+    computeLayout(parsed)
+      .then((result) => {
+        if (!cancelled) setLayout(result);
+      })
+      .catch((err: unknown) => {
+        if (!cancelled) {
+          // biome-ignore lint/suspicious/noConsole: layout error reporting
+          console.error("ELK layout failed:", err);
+        }
+      });
    return () => {
      cancelled = true;
    };