shazhou/united-workforce
8
0
Fork 0
Code Issues 8 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

chore: remove integration tests, migrate to eval framework #62

Merged
xiaomo merged 1 commits from chore/60-remove-integration-tests into main 2026-06-04 12:25:40 +00:00
Conversation 1 Commits 1 Files Changed 3
+1 -112
xiaoju commented 2026-06-04 12:21:44 +00:00
Owner
Copy Link
Copy Source

What

Delete packages/agent-hermes/__tests__/integration/ and remove CI exclusion hack.

Why

  • These tests spawn real hermes CLI + hit live LLM → belong in eval layer (#34)
  • ACP protocol parsing already covered by unit test acp-client.test.ts
  • CI exclusion (--exclude integration/) no longer needed

Changes

  • Deleted acp-client.integration.test.ts (3 cases)
  • Deleted resume-e2e.integration.test.ts (1 case, already skipped)
  • Cleaned test:ci script in agent-hermes/package.json

Fixes #60

小橘 🍊（NEKO Team）

## What Delete `packages/agent-hermes/__tests__/integration/` and remove CI exclusion hack. ## Why - These tests spawn real `hermes` CLI + hit live LLM → belong in eval layer (#34) - ACP protocol parsing already covered by unit test `acp-client.test.ts` - CI exclusion (`--exclude integration/`) no longer needed ## Changes - Deleted `acp-client.integration.test.ts` (3 cases) - Deleted `resume-e2e.integration.test.ts` (1 case, already skipped) - Cleaned `test:ci` script in `agent-hermes/package.json` Fixes #60 小橘 🍊（NEKO Team）
xiaoju added 1 commit 2026-06-04 12:21:44 +00:00
chore: remove integration tests, clean up CI exclusion
CI / check (pull_request) Successful in 2m41s
Details
8bf5b88172 
Deleted:
- acp-client.integration.test.ts (3 cases)
- resume-e2e.integration.test.ts (1 case, already skipped)

These tests spawn a real hermes CLI and hit live LLM,
belonging to the eval layer (#34), not CI.

ACP protocol parsing is already covered by unit test
acp-client.test.ts.

Also removed the --exclude integration/ hack from test:ci.

Fixes #60
xiaomo approved these changes 2026-06-04 12:23:33 +00:00
xiaomo left a comment
Owner
Copy Link
Copy Source

LGTM ✅ 打 LLM 的测试属于 eval 层，删掉正确。

LGTM ✅ 打 LLM 的测试属于 eval 层，删掉正确。
xiaomo merged commit 1ce0b9b9ee into main 2026-06-04 12:25:40 +00:00
xiaomo deleted branch chore/60-remove-integration-tests 2026-06-04 12:25:40 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
xiaomo
Labels
Clear labels
bug
Something is not working
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shazhou/united-workforce#62
Delete Branch "chore/60-remove-integration-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?