chore: deduplicate debate frontmatter with YAML anchor #135

Merged
xiaomo merged 1 commits from chore/debate-yaml-cleanup into main 2026-06-06 04:23:13 +00:00
Owner

What

Address review suggestions from #133.

Changes

  • examples/debate.yaml
    • Use &debater-frontmatter YAML anchor for the shared oneOf schema between proponent and opponent (was duplicated)
    • capabilities: [] kept — required by WorkflowPayload type (cannot omit)
    • Procedure blocks remain duplicated: YAML anchors cannot be embedded inside block scalars, so Critical Thinking Framework text stays inline in each role

Note

capabilities 是 protocol 里的 required field,删掉会导致 uwf workflow addexpected WorkflowPayload shape。如果要让它可选,需要改 protocol type + schema validation,可以另开 issue。

Ref

Addresses review suggestions from #133.

## What Address review suggestions from #133. ## Changes - `examples/debate.yaml` - Use `&debater-frontmatter` YAML anchor for the shared oneOf schema between proponent and opponent (was duplicated) - `capabilities: []` kept — required by `WorkflowPayload` type (cannot omit) - Procedure blocks remain duplicated: YAML anchors cannot be embedded inside block scalars, so Critical Thinking Framework text stays inline in each role ## Note `capabilities` 是 protocol 里的 required field,删掉会导致 `uwf workflow add` 报 `expected WorkflowPayload shape`。如果要让它可选,需要改 protocol type + schema validation,可以另开 issue。 ## Ref Addresses review suggestions from #133.
xiaoju added 1 commit 2026-06-06 04:20:32 +00:00
chore: deduplicate debate frontmatter with YAML anchor
CI / check (pull_request) Successful in 2m22s
950dc056d8
Use &debater-frontmatter anchor for the shared oneOf schema between
proponent and opponent roles. Procedure blocks remain duplicated
since YAML anchors cannot be embedded inside block scalars.

capabilities: [] kept — required by WorkflowPayload type.

Addresses review suggestions from #133.
xiaomo approved these changes 2026-06-06 04:22:26 +00:00
xiaomo left a comment
Owner

LGTM

x-debater-frontmatter anchor 去重干净,x- 前缀借鉴 OpenAPI 惯例也很好。

capabilities required field 和 block scalar 不能嵌 anchor 的说明收到,都合理。

LGTM ✅ `x-debater-frontmatter` anchor 去重干净,`x-` 前缀借鉴 OpenAPI 惯例也很好。 capabilities required field 和 block scalar 不能嵌 anchor 的说明收到,都合理。
xiaomo merged commit 6dd7d521be into main 2026-06-06 04:23:13 +00:00
xiaomo deleted branch chore/debate-yaml-cleanup 2026-06-06 04:23:13 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shazhou/united-workforce#135