uncaged/nerve
Archived
10
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(test): align tests with type-safety refactor #91

Merged
xingyue merged 1 commits from fix/test-failures-after-type-safety-refactor into main 2026-04-24 12:24:51 +00:00
Conversation 0 Commits 1 Files Changed 5
+106 -51
xiaoju commented 2026-04-24 12:23:35 +00:00
Owner
Copy Link
Copy Source

What

Fix 12 test failures caused by the type-safety refactor (PRs #88, #89).

Why

Tests were asserting old behavior (workflow reflexes in YAML, loose typing) that was intentionally removed.

Changes

  • core/config.test.ts — workflow reflex tests now expect not supported error message
  • cli/workflow.test.ts — partitionWorkflowMessage test uses strict typed params
  • daemon/crash-recovery.test.ts — remove triggerPayload from resume-thread assertion
  • daemon/daemon-ipc.test.ts — trigger-workflow sends prompt+maxRounds instead of payload
  • daemon/kernel-workflow-integration.test.ts — use Sense-driven workflow trigger pattern

Verification

All 367 tests pass across all packages (core 21, store 73, cli 122, daemon 151).

Ref

Refs #88, #89

## What Fix 12 test failures caused by the type-safety refactor (PRs #88, #89). ## Why Tests were asserting old behavior (workflow reflexes in YAML, loose typing) that was intentionally removed. ## Changes - **core/config.test.ts** — workflow reflex tests now expect `not supported` error message - **cli/workflow.test.ts** — `partitionWorkflowMessage` test uses strict typed params - **daemon/crash-recovery.test.ts** — remove `triggerPayload` from resume-thread assertion - **daemon/daemon-ipc.test.ts** — trigger-workflow sends `prompt`+`maxRounds` instead of `payload` - **daemon/kernel-workflow-integration.test.ts** — use Sense-driven workflow trigger pattern ## Verification All 367 tests pass across all packages (core 21, store 73, cli 122, daemon 151). ## Ref Refs #88, #89
xiaoju added 1 commit 2026-04-24 12:23:35 +00:00
fix(test): align tests with type-safety refactor 8807b0ac6a 
Update test expectations after workflow reflexes were removed from
YAML config and type signatures were tightened:

- core/config: workflow reflex tests now expect 'not supported' error
- cli/workflow: partitionWorkflowMessage test uses strict typed params
- daemon/crash-recovery: remove triggerPayload from resume-thread assertion
- daemon/daemon-ipc: trigger-workflow sends prompt+maxRounds
- daemon/kernel-workflow: use Sense-driven workflow trigger pattern

Fixes 12 test failures across core, cli, and daemon packages.

Refs #88, #89
xingyue merged commit 788ebc6779 into main 2026-04-24 12:24:51 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/nerve#91
Delete Branch "fix/test-failures-after-type-safety-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?