chore(cli): clean up step-ask nits from PR #156 review #158

2026-06-07T11:51:49Z

xiaoju commented

2026-06-07 11:51:49 +00:00

What

Clean up 4 minor nits identified in PR #156 review.

Changes

Remove dead-code detailRef !== null guards (already validated at L525)
Fix ?: to explicit T | null on external error type boundary
Drop unnecessary async from resolveAskWorkflow (no await inside)
Simplify double negation: opts.fork !== false → opts.fork

Verification

pnpm run build ✓
pnpm run typecheck ✓
pnpm run check ✓
pnpm run test ✓ (91 files / 867 tests)

Ref

Refs #146

## What Clean up 4 minor nits identified in PR #156 review. ## Changes 1. Remove dead-code `detailRef !== null` guards (already validated at L525) 2. Fix `?:` to explicit `T | null` on external error type boundary 3. Drop unnecessary `async` from `resolveAskWorkflow` (no await inside) 4. Simplify double negation: `opts.fork !== false` → `opts.fork` ## Verification - pnpm run build ✓ - pnpm run typecheck ✓ - pnpm run check ✓ - pnpm run test ✓ (91 files / 867 tests) ## Ref Refs #146

xiaoju added 1 commit 2026-06-07 11:51:49 +00:00

chore(cli): clean up step-ask nits from PR #156 review

CI / check (pull_request) Successful in 2m23s

Details

10113f6ec6

- Remove dead-code detailRef null guards (already validated upstream)
- Fix ?: to explicit T | null on external error type boundary
- Drop unnecessary async from resolveAskWorkflow (no await)
- Simplify double negation: opts.fork !== false → opts.fork

Refs #146

xingyue approved these changes 2026-06-07 11:57:49 +00:00

xingyue left a comment

LGTM ✅ 我 review 里的 4 个 nit 全修了，干净利落 👏

xingyue merged commit e1c7e3d267 into main

2026-06-07 11:57:52 +00:00

xingyue deleted branch chore/156-nits

2026-06-07 11:57:52 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: shazhou/united-workforce#158